perf: 优化字典管理模块service层及异常处理

ruoyi-fastapi-backend/module_admin/controller/dict_controller.py

@@ -18,226 +18,153 @@ dictController = APIRouter(prefix='/system/dict', dependencies=[Depends(LoginSer
 
 @dictController.get("/type/list", response_model=PageResponseModel, dependencies=[Depends(CheckUserInterfaceAuth('system:dict:list'))])
 async def get_system_dict_type_list(request: Request, dict_type_page_query: DictTypePageQueryModel = Depends(DictTypePageQueryModel.as_query), query_db: AsyncSession = Depends(get_db)):
-    try:
     # 获取分页数据
     dict_type_page_query_result = await DictTypeService.get_dict_type_list_services(query_db, dict_type_page_query, is_page=True)
     logger.info('获取成功')
+
     return ResponseUtil.success(model_content=dict_type_page_query_result)
-    except Exception as e:
-        logger.exception(e)
-        return ResponseUtil.error(msg=str(e))
 
 
 @dictController.post("/type", dependencies=[Depends(CheckUserInterfaceAuth('system:dict:add'))])
 @ValidateFields(validate_model='add_dict_type')
 @log_decorator(title='字典管理', business_type=BusinessType.INSERT)
 async def add_system_dict_type(request: Request, add_dict_type: DictTypeModel, query_db: AsyncSession = Depends(get_db), current_user: CurrentUserModel = Depends(LoginService.get_current_user)):
-    try:
     add_dict_type.create_by = current_user.user.user_name
     add_dict_type.create_time = datetime.now()
     add_dict_type.update_by = current_user.user.user_name
     add_dict_type.update_time = datetime.now()
     add_dict_type_result = await DictTypeService.add_dict_type_services(request, query_db, add_dict_type)
-        if add_dict_type_result.is_success:
     logger.info(add_dict_type_result.message)
+
     return ResponseUtil.success(msg=add_dict_type_result.message)
-        else:
-            logger.warning(add_dict_type_result.message)
-            return ResponseUtil.failure(msg=add_dict_type_result.message)
-    except Exception as e:
-        logger.exception(e)
-        return ResponseUtil.error(msg=str(e))
 
 
 @dictController.put("/type", dependencies=[Depends(CheckUserInterfaceAuth('system:dict:edit'))])
 @ValidateFields(validate_model='edit_dict_type')
 @log_decorator(title='字典管理', business_type=BusinessType.UPDATE)
 async def edit_system_dict_type(request: Request, edit_dict_type: DictTypeModel, query_db: AsyncSession = Depends(get_db), current_user: CurrentUserModel = Depends(LoginService.get_current_user)):
-    try:
     edit_dict_type.update_by = current_user.user.user_name
     edit_dict_type.update_time = datetime.now()
     edit_dict_type_result = await DictTypeService.edit_dict_type_services(request, query_db, edit_dict_type)
-        if edit_dict_type_result.is_success:
     logger.info(edit_dict_type_result.message)
+
     return ResponseUtil.success(msg=edit_dict_type_result.message)
-        else:
-            logger.warning(edit_dict_type_result.message)
-            return ResponseUtil.failure(msg=edit_dict_type_result.message)
-    except Exception as e:
-        logger.exception(e)
-        return ResponseUtil.error(msg=str(e))
 
 
 @dictController.delete("/type/refreshCache", dependencies=[Depends(CheckUserInterfaceAuth('system:dict:remove'))])
 @log_decorator(title='字典管理', business_type=BusinessType.UPDATE)
 async def refresh_system_dict(request: Request, query_db: AsyncSession = Depends(get_db)):
-    try:
     refresh_dict_result = await DictTypeService.refresh_sys_dict_services(request, query_db)
-        if refresh_dict_result.is_success:
     logger.info(refresh_dict_result.message)
+
     return ResponseUtil.success(msg=refresh_dict_result.message)
-        else:
-            logger.warning(refresh_dict_result.message)
-            return ResponseUtil.failure(msg=refresh_dict_result.message)
-    except Exception as e:
-        logger.exception(e)
-        return ResponseUtil.error(msg=str(e))
 
 
 @dictController.delete("/type/{dict_ids}", dependencies=[Depends(CheckUserInterfaceAuth('system:dict:remove'))])
 @log_decorator(title='字典管理', business_type=BusinessType.DELETE)
 async def delete_system_dict_type(request: Request, dict_ids: str, query_db: AsyncSession = Depends(get_db)):
-    try:
     delete_dict_type = DeleteDictTypeModel(dictIds=dict_ids)
     delete_dict_type_result = await DictTypeService.delete_dict_type_services(request, query_db, delete_dict_type)
-        if delete_dict_type_result.is_success:
     logger.info(delete_dict_type_result.message)
+
     return ResponseUtil.success(msg=delete_dict_type_result.message)
-        else:
-            logger.warning(delete_dict_type_result.message)
-            return ResponseUtil.failure(msg=delete_dict_type_result.message)
-    except Exception as e:
-        logger.exception(e)
-        return ResponseUtil.error(msg=str(e))
 
 
 @dictController.get("/type/optionselect", response_model=List[DictTypeModel])
 async def query_system_dict_type_options(request: Request, query_db: AsyncSession = Depends(get_db)):
-    try:
     dict_type_query_result = await DictTypeService.get_dict_type_list_services(query_db, DictTypePageQueryModel(**dict()), is_page=False)
     logger.info(f'获取成功')
+
     return ResponseUtil.success(data=dict_type_query_result)
-    except Exception as e:
-        logger.exception(e)
-        return ResponseUtil.error(msg=str(e))
 
 
 @dictController.get("/type/{dict_id}", response_model=DictTypeModel, dependencies=[Depends(CheckUserInterfaceAuth('system:dict:query'))])
 async def query_detail_system_dict_type(request: Request, dict_id: int, query_db: AsyncSession = Depends(get_db)):
-    try:
     dict_type_detail_result = await DictTypeService.dict_type_detail_services(query_db, dict_id)
     logger.info(f'获取dict_id为{dict_id}的信息成功')
+
     return ResponseUtil.success(data=dict_type_detail_result)
-    except Exception as e:
-        logger.exception(e)
-        return ResponseUtil.error(msg=str(e))
 
 
 @dictController.post("/type/export", dependencies=[Depends(CheckUserInterfaceAuth('system:dict:export'))])
 @log_decorator(title='字典管理', business_type=BusinessType.EXPORT)
 async def export_system_dict_type_list(request: Request, dict_type_page_query: DictTypePageQueryModel = Depends(DictTypePageQueryModel.as_form), query_db: AsyncSession = Depends(get_db)):
-    try:
     # 获取全量数据
     dict_type_query_result = await DictTypeService.get_dict_type_list_services(query_db, dict_type_page_query, is_page=False)
     dict_type_export_result = await DictTypeService.export_dict_type_list_services(dict_type_query_result)
     logger.info('导出成功')
+
     return ResponseUtil.streaming(data=bytes2file_response(dict_type_export_result))
-    except Exception as e:
-        logger.exception(e)
-        return ResponseUtil.error(msg=str(e))
 
 
 @dictController.get("/data/type/{dict_type}")
 async def query_system_dict_type_data(request: Request, dict_type: str, query_db: AsyncSession = Depends(get_db)):
-    try:
     # 获取全量数据
     dict_data_query_result = await DictDataService.query_dict_data_list_from_cache_services(request.app.state.redis, dict_type)
     logger.info('获取成功')
+
     return ResponseUtil.success(data=dict_data_query_result)
-    except Exception as e:
-        logger.exception(e)
-        return ResponseUtil.error(msg=str(e))
 
 
 @dictController.get("/data/list", response_model=PageResponseModel, dependencies=[Depends(CheckUserInterfaceAuth('system:dict:list'))])
 async def get_system_dict_data_list(request: Request, dict_data_page_query: DictDataPageQueryModel = Depends(DictDataPageQueryModel.as_query), query_db: AsyncSession = Depends(get_db)):
-    try:
     # 获取分页数据
     dict_data_page_query_result = await DictDataService.get_dict_data_list_services(query_db, dict_data_page_query, is_page=True)
     logger.info('获取成功')
+
     return ResponseUtil.success(model_content=dict_data_page_query_result)
-    except Exception as e:
-        logger.exception(e)
-        return ResponseUtil.error(msg=str(e))
 
 
 @dictController.post("/data", dependencies=[Depends(CheckUserInterfaceAuth('system:dict:add'))])
 @ValidateFields(validate_model='add_dict_data')
 @log_decorator(title='字典管理', business_type=BusinessType.INSERT)
 async def add_system_dict_data(request: Request, add_dict_data: DictDataModel, query_db: AsyncSession = Depends(get_db), current_user: CurrentUserModel = Depends(LoginService.get_current_user)):
-    try:
     add_dict_data.create_by = current_user.user.user_name
     add_dict_data.create_time = datetime.now()
     add_dict_data.update_by = current_user.user.user_name
     add_dict_data.update_time = datetime.now()
     add_dict_data_result = await DictDataService.add_dict_data_services(request, query_db, add_dict_data)
-        if add_dict_data_result.is_success:
     logger.info(add_dict_data_result.message)
+
     return ResponseUtil.success(msg=add_dict_data_result.message)
-        else:
-            logger.warning(add_dict_data_result.message)
-            return ResponseUtil.failure(msg=add_dict_data_result.message)
-    except Exception as e:
-        logger.exception(e)
-        return ResponseUtil.error(msg=str(e))
 
 
 @dictController.put("/data", dependencies=[Depends(CheckUserInterfaceAuth('system:dict:edit'))])
 @ValidateFields(validate_model='edit_dict_data')
 @log_decorator(title='字典管理', business_type=BusinessType.UPDATE)
 async def edit_system_dict_data(request: Request, edit_dict_data: DictDataModel, query_db: AsyncSession = Depends(get_db), current_user: CurrentUserModel = Depends(LoginService.get_current_user)):
-    try:
     edit_dict_data.update_by = current_user.user.user_name
     edit_dict_data.update_time = datetime.now()
     edit_dict_data_result = await DictDataService.edit_dict_data_services(request, query_db, edit_dict_data)
-        if edit_dict_data_result.is_success:
     logger.info(edit_dict_data_result.message)
+
     return ResponseUtil.success(msg=edit_dict_data_result.message)
-        else:
-            logger.warning(edit_dict_data_result.message)
-            return ResponseUtil.failure(msg=edit_dict_data_result.message)
-    except Exception as e:
-        logger.exception(e)
-        return ResponseUtil.error(msg=str(e))
 
 
 @dictController.delete("/data/{dict_codes}", dependencies=[Depends(CheckUserInterfaceAuth('system:dict:remove'))])
 @log_decorator(title='字典管理', business_type=BusinessType.DELETE)
 async def delete_system_dict_data(request: Request, dict_codes: str, query_db: AsyncSession = Depends(get_db)):
-    try:
     delete_dict_data = DeleteDictDataModel(dictCodes=dict_codes)
     delete_dict_data_result = await DictDataService.delete_dict_data_services(request, query_db, delete_dict_data)
-        if delete_dict_data_result.is_success:
     logger.info(delete_dict_data_result.message)
+
     return ResponseUtil.success(msg=delete_dict_data_result.message)
-        else:
-            logger.warning(delete_dict_data_result.message)
-            return ResponseUtil.failure(msg=delete_dict_data_result.message)
-    except Exception as e:
-        logger.exception(e)
-        return ResponseUtil.error(msg=str(e))
 
 
 @dictController.get("/data/{dict_code}", response_model=DictDataModel, dependencies=[Depends(CheckUserInterfaceAuth('system:dict:query'))])
 async def query_detail_system_dict_data(request: Request, dict_code: int, query_db: AsyncSession = Depends(get_db)):
-    try:
     detail_dict_data_result = await DictDataService.dict_data_detail_services(query_db, dict_code)
     logger.info(f'获取dict_code为{dict_code}的信息成功')
+
     return ResponseUtil.success(data=detail_dict_data_result)
-    except Exception as e:
-        logger.exception(e)
-        return ResponseUtil.error(msg=str(e))
 
 
 @dictController.post("/data/export", dependencies=[Depends(CheckUserInterfaceAuth('system:dict:export'))])
 @log_decorator(title='字典管理', business_type=BusinessType.EXPORT)
 async def export_system_dict_data_list(request: Request, dict_data_page_query: DictDataPageQueryModel = Depends(DictDataPageQueryModel.as_form), query_db: AsyncSession = Depends(get_db)):
-    try:
     # 获取全量数据
     dict_data_query_result = await DictDataService.get_dict_data_list_services(query_db, dict_data_page_query, is_page=False)
     dict_data_export_result = await DictDataService.export_dict_data_list_services(dict_data_query_result)
     logger.info('导出成功')
+
     return ResponseUtil.streaming(data=bytes2file_response(dict_data_export_result))
-    except Exception as e:
-        logger.exception(e)
-        return ResponseUtil.error(msg=str(e))

ruoyi-fastapi-backend/module_admin/dao/dict_dao.py

@@ -1,4 +1,4 @@
-from sqlalchemy import select, update, delete, and_
+from sqlalchemy import select, update, delete, and_, func
 from sqlalchemy.ext.asyncio import AsyncSession
 from module_admin.entity.do.dict_do import SysDictType, SysDictData
 from module_admin.entity.vo.dict_vo import *
@@ -149,9 +149,9 @@ class DictDataDao:
         """
         dict_data_info = (await db.execute(
             select(SysDictData)
-                .where(SysDictData.dict_type == dict_data.dict_type if dict_data.dict_type else True,
-                       SysDictData.dict_label == dict_data.dict_label if dict_data.dict_label else True,
-                       SysDictData.dict_value == dict_data.dict_value if dict_data.dict_value else True)
+                .where(SysDictData.dict_type == dict_data.dict_type,
+                       SysDictData.dict_label == dict_data.dict_label,
+                       SysDictData.dict_value == dict_data.dict_value)
         )).scalars().first()
 
         return dict_data_info
@@ -233,3 +233,19 @@ class DictDataDao:
             delete(SysDictData)
                 .where(SysDictData.dict_code.in_([dict_data.dict_code]))
         )
+
+    @classmethod
+    async def count_dict_data_dao(cls, db: AsyncSession, dict_type: str):
+        """
+        根据字典类型查询字典类型关联的字典数据数量
+        :param db: orm对象
+        :param dict_type: 字典类型
+        :return: 字典类型关联的字典数据数量
+        """
+        dict_data_count = (await db.execute(
+            select(func.count('*'))
+                .select_from(SysDictData)
+                .where(SysDictData.dict_type == dict_type)
+        )).scalar()
+
+        return dict_data_count

ruoyi-fastapi-backend/module_admin/service/dict_service.py

@@ -1,8 +1,10 @@
 from fastapi import Request
 import json
-from config.env import RedisInitKeyConfig
 from module_admin.dao.dict_dao import *
 from module_admin.entity.vo.common_vo import CrudResponseModel
+from config.constant import CommonConstant
+from config.env import RedisInitKeyConfig
+from exceptions.exception import ServiceException
 from utils.common_util import export_list2excel, CamelCaseUtil
 
 
@@ -24,6 +26,20 @@ class DictTypeService:
 
         return dict_type_list_result
 
+    @classmethod
+    async def check_dict_type_unique_services(cls, query_db: AsyncSession, page_object: DictTypeModel):
+        """
+        校验字典类型称是否唯一service
+        :param query_db: orm对象
+        :param page_object: 字典类型对象
+        :return: 校验结果
+        """
+        dict_id = -1 if page_object.dict_id is None else page_object.dict_id
+        dict_type = await DictTypeDao.get_dict_type_detail_by_info(query_db, DictTypeModel(dictType=page_object.dict_type))
+        if dict_type and dict_type.dict_id != dict_id:
+            return CommonConstant.NOT_UNIQUE
+        return CommonConstant.UNIQUE
+
     @classmethod
     async def add_dict_type_services(cls, request: Request, query_db: AsyncSession, page_object: DictTypeModel):
         """
@@ -33,14 +49,13 @@ class DictTypeService:
         :param page_object: 新增岗位对象
         :return: 新增字典类型校验结果
         """
-        dict_type = await DictTypeDao.get_dict_type_detail_by_info(query_db, DictTypeModel(dictType=page_object.dict_type))
-        if dict_type:
-            result = dict(is_success=False, message='字典类型已存在')
+        if not await cls.check_dict_type_unique_services(query_db, page_object):
+            raise ServiceException(message=f'新增字典{page_object.dict_name}失败，字典类型已存在')
         else:
             try:
                 await DictTypeDao.add_dict_type_dao(query_db, page_object)
                 await query_db.commit()
-                await DictDataService.init_cache_sys_dict_services(query_db, request.app.state.redis)
+                await request.app.state.redis.set(f"{RedisInitKeyConfig.SYS_DICT.get('key')}:{page_object.dict_type}", '')
                 result = dict(is_success=True, message='新增成功')
             except Exception as e:
                 await query_db.rollback()
@@ -58,31 +73,29 @@ class DictTypeService:
         :return: 编辑字典类型校验结果
         """
         edit_dict_type = page_object.model_dump(exclude_unset=True)
-        dict_type_info = await cls.dict_type_detail_services(query_db, edit_dict_type.get('dict_id'))
-        if dict_type_info:
-            if dict_type_info.dict_type != page_object.dict_type or dict_type_info.dict_name != page_object.dict_name:
-                dict_type = await DictTypeDao.get_dict_type_detail_by_info(query_db, DictTypeModel(dictType=page_object.dict_type))
-                if dict_type:
-                    result = dict(is_success=False, message='字典类型已存在')
-                    return CrudResponseModel(**result)
+        dict_type_info = await cls.dict_type_detail_services(query_db, page_object.dict_id)
+        if dict_type_info.dict_id:
+            if not await cls.check_dict_type_unique_services(query_db, page_object):
+                raise ServiceException(message=f'修改字典{page_object.dict_name}失败，字典类型已存在')
+            else:
                 try:
-                if dict_type_info.dict_type != page_object.dict_type:
                     query_dict_data = DictDataPageQueryModel(dictType=dict_type_info.dict_type)
                     dict_data_list = await DictDataDao.get_dict_data_list(query_db, query_dict_data, is_page=False)
+                    if dict_type_info.dict_type != page_object.dict_type:
                         for dict_data in dict_data_list:
                             edit_dict_data = DictDataModel(dictCode=dict_data.dict_code, dictType=page_object.dict_type, updateBy=page_object.update_by).model_dump(exclude_unset=True)
                             await DictDataDao.edit_dict_data_dao(query_db, edit_dict_data)
                     await DictTypeDao.edit_dict_type_dao(query_db, edit_dict_type)
                     await query_db.commit()
-                await DictDataService.init_cache_sys_dict_services(query_db, request.app.state.redis)
-                result = dict(is_success=True, message='更新成功')
+                    if dict_type_info.dict_type != page_object.dict_type:
+                        dict_data = [CamelCaseUtil.transform_result(row) for row in dict_data_list if row]
+                        await request.app.state.redis.set(f"{RedisInitKeyConfig.SYS_DICT.get('key')}:{page_object.dict_type}", json.dumps(dict_data, ensure_ascii=False, default=str))
+                    return CrudResponseModel(is_success=True, message='更新成功')
                 except Exception as e:
                     await query_db.rollback()
                     raise e
         else:
-            result = dict(is_success=False, message='字典类型不存在')
-
-        return CrudResponseModel(**result)
+            raise ServiceException(message='字典类型不存在')
 
     @classmethod
     async def delete_dict_type_services(cls, request: Request, query_db: AsyncSession, page_object: DeleteDictTypeModel):
@@ -96,17 +109,22 @@ class DictTypeService:
         if page_object.dict_ids.split(','):
             dict_id_list = page_object.dict_ids.split(',')
             try:
+                delete_dict_type_list = []
                 for dict_id in dict_id_list:
-                    await DictTypeDao.delete_dict_type_dao(query_db, DictTypeModel(dictId=dict_id))
+                    dict_type_into = await cls.dict_type_detail_services(query_db, int(dict_id))
+                    if (await DictDataDao.count_dict_data_dao(query_db, dict_type_into.dict_type)) > 0:
+                        raise ServiceException(message=f'{dict_type_into.dict_name}已分配，不能删除')
+                    await DictTypeDao.delete_dict_type_dao(query_db, DictTypeModel(dictId=int(dict_id)))
+                    delete_dict_type_list.append(f"{RedisInitKeyConfig.SYS_DICT.get('key')}:{dict_type_into.dict_type}")
                 await query_db.commit()
-                await DictDataService.init_cache_sys_dict_services(query_db, request.app.state.redis)
-                result = dict(is_success=True, message='删除成功')
+                if delete_dict_type_list:
+                    await request.app.state.redis.delete(*delete_dict_type_list)
+                return CrudResponseModel(is_success=True, message='删除成功')
             except Exception as e:
                 await query_db.rollback()
                 raise e
         else:
-            result = dict(is_success=False, message='传入字典类型id为空')
-        return CrudResponseModel(**result)
+            raise ServiceException(message='传入字典类型id为空')
 
     @classmethod
     async def dict_type_detail_services(cls, query_db: AsyncSession, dict_id: int):
@@ -117,7 +135,10 @@ class DictTypeService:
         :return: 字典类型id对应的信息
         """
         dict_type = await DictTypeDao.get_dict_type_detail_by_id(query_db, dict_id=dict_id)
+        if dict_type:
             result = DictTypeModel(**CamelCaseUtil.transform_result(dict_type))
+        else:
+            result = DictTypeModel(**dict())
 
         return result
 
@@ -232,6 +253,20 @@ class DictDataService:
 
         return CamelCaseUtil.transform_result(result)
 
+    @classmethod
+    async def check_dict_data_unique_services(cls, query_db: AsyncSession, page_object: DictDataModel):
+        """
+        校验字典数据是否唯一service
+        :param query_db: orm对象
+        :param page_object: 字典数据对象
+        :return: 校验结果
+        """
+        dict_code = -1 if page_object.dict_code is None else page_object.dict_code
+        dict_data = await DictDataDao.get_dict_data_detail_by_info(query_db, page_object)
+        if dict_data and dict_data.dict_code != dict_code:
+            return CommonConstant.NOT_UNIQUE
+        return CommonConstant.UNIQUE
+
     @classmethod
     async def add_dict_data_services(cls, request: Request, query_db: AsyncSession, page_object: DictDataModel):
         """
@@ -241,21 +276,19 @@ class DictDataService:
         :param page_object: 新增岗位对象
         :return: 新增字典数据校验结果
         """
-        dict_data = await DictDataDao.get_dict_data_detail_by_info(query_db, page_object)
-        if dict_data:
-            result = dict(is_success=False, message='字典数据已存在')
+        if not await cls.check_dict_data_unique_services(query_db, page_object):
+            raise ServiceException(message=f'新增字典数据{page_object.dict_label}失败，{page_object.dict_type}下已存在该字典数据')
         else:
             try:
                 await DictDataDao.add_dict_data_dao(query_db, page_object)
                 await query_db.commit()
-                await cls.init_cache_sys_dict_services(query_db, request.app.state.redis)
-                result = dict(is_success=True, message='新增成功')
+                dict_data_list = await cls.query_dict_data_list_services(query_db, page_object.dict_type)
+                await request.app.state.redis.set(f"{RedisInitKeyConfig.SYS_DICT.get('key')}:{page_object.dict_type}", json.dumps(CamelCaseUtil.transform_result(dict_data_list), ensure_ascii=False, default=str))
+                return CrudResponseModel(is_success=True, message='新增成功')
             except Exception as e:
                 await query_db.rollback()
                 raise e
 
-        return CrudResponseModel(**result)
-
     @classmethod
     async def edit_dict_data_services(cls, request: Request, query_db: AsyncSession, page_object: DictDataModel):
         """
@@ -266,25 +299,22 @@ class DictDataService:
         :return: 编辑字典数据校验结果
         """
         edit_data_type = page_object.model_dump(exclude_unset=True)
-        dict_data_info = await cls.dict_data_detail_services(query_db, edit_data_type.get('dict_code'))
-        if dict_data_info:
-            if dict_data_info.dict_type != page_object.dict_type or dict_data_info.dict_label != page_object.dict_label or dict_data_info.dict_value != page_object.dict_value:
-                dict_data = await DictDataDao.get_dict_data_detail_by_info(query_db, page_object)
-                if dict_data:
-                    result = dict(is_success=False, message='字典数据已存在')
-                    return CrudResponseModel(**result)
+        dict_data_info = await cls.dict_data_detail_services(query_db, page_object.dict_code)
+        if dict_data_info.dict_code:
+            if not await cls.check_dict_data_unique_services(query_db, page_object):
+                raise ServiceException(message=f'新增字典数据{page_object.dict_label}失败，{page_object.dict_type}下已存在该字典数据')
+            else:
                 try:
                     await DictDataDao.edit_dict_data_dao(query_db, edit_data_type)
                     await query_db.commit()
-                await cls.init_cache_sys_dict_services(query_db, request.app.state.redis)
-                result = dict(is_success=True, message='更新成功')
+                    dict_data_list = await cls.query_dict_data_list_services(query_db, page_object.dict_type)
+                    await request.app.state.redis.set(f"{RedisInitKeyConfig.SYS_DICT.get('key')}:{page_object.dict_type}", json.dumps(CamelCaseUtil.transform_result(dict_data_list), ensure_ascii=False, default=str))
+                    return CrudResponseModel(is_success=True, message='更新成功')
                 except Exception as e:
                     await query_db.rollback()
                     raise e
         else:
-            result = dict(is_success=False, message='字典数据不存在')
-
-        return CrudResponseModel(**result)
+            raise ServiceException(message='字典数据不存在')
 
     @classmethod
     async def delete_dict_data_services(cls, request: Request, query_db: AsyncSession, page_object: DeleteDictDataModel):
@@ -298,17 +328,21 @@ class DictDataService:
         if page_object.dict_codes.split(','):
             dict_code_list = page_object.dict_codes.split(',')
             try:
+                delete_dict_type_list = []
                 for dict_code in dict_code_list:
+                    dict_data = await cls.dict_data_detail_services(query_db, int(dict_code))
                     await DictDataDao.delete_dict_data_dao(query_db, DictDataModel(dictCode=dict_code))
+                    delete_dict_type_list.append(dict_data.dict_type)
                 await query_db.commit()
-                await cls.init_cache_sys_dict_services(query_db, request.app.state.redis)
-                result = dict(is_success=True, message='删除成功')
+                for dict_type in list(set(delete_dict_type_list)):
+                    dict_data_list = await cls.query_dict_data_list_services(query_db, dict_type)
+                    await request.app.state.redis.set(f"{RedisInitKeyConfig.SYS_DICT.get('key')}:{dict_type}", json.dumps(CamelCaseUtil.transform_result(dict_data_list), ensure_ascii=False, default=str))
+                return CrudResponseModel(is_success=True, message='删除成功')
             except Exception as e:
                 await query_db.rollback()
                 raise e
         else:
-            result = dict(is_success=False, message='传入字典数据id为空')
-        return CrudResponseModel(**result)
+            raise ServiceException(message='传入字典数据id为空')
 
     @classmethod
     async def dict_data_detail_services(cls, query_db: AsyncSession, dict_code: int):
@@ -319,7 +353,10 @@ class DictDataService:
         :return: 字典数据id对应的信息
         """
         dict_data = await DictDataDao.get_dict_data_detail_by_id(query_db, dict_code=dict_code)
+        if dict_data:
             result = DictDataModel(**CamelCaseUtil.transform_result(dict_data))
+        else:
+            result = DictDataModel(**dict())
 
         return result